Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 tests for uploading files. #52

Open
FledgeXu opened this issue Aug 23, 2023 · 1 comment
Open

Add S3 tests for uploading files. #52

FledgeXu opened this issue Aug 23, 2023 · 1 comment
Labels
backend enhancement New feature or request

Comments

@FledgeXu
Copy link
Collaborator

So far, we haven't tested the S3 upload file part, we need to add this part of the test

@rgaudin rgaudin added enhancement New feature or request backend labels Jun 20, 2024
@rgaudin
Copy link
Member

rgaudin commented Jun 20, 2024

The S3 upload is not tested but some higher level tests depend on S3 so the upload code is run in tests. This is problematic because it requires valid S3 URL/credentials to run tests.

We also have tests mocking S3.

This ticket should thus:

  • create independent Upload-testing test that require a valid URL and are run conditionally via a mark.
  • use mocked S3 for all other tests so by default S3 URL is not required for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants