Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide kiwix-serve taskbar in embedded iframes #135

Open
IPECORE opened this issue Aug 25, 2020 · 3 comments
Open

Hide kiwix-serve taskbar in embedded iframes #135

IPECORE opened this issue Aug 25, 2020 · 3 comments

Comments

@IPECORE
Copy link

IPECORE commented Aug 25, 2020

If I click on one of the 3 "icons" or texts in this line, it brings me back to the start. You can just delete it.
unnecessary line between text and illustration

@satyamtg satyamtg changed the title topic 6, Unit 2, step 2, task 3. Unnecessary line between text and graphic topic 5, Unit 2, step 2, task 3. Unnecessary line between text and graphic Aug 25, 2020
@satyamtg
Copy link
Contributor

@IPECORE are you talking about this -

91179477-d5ad6a80-e6e6-11ea-9939-f04c58e03016

If yes, then that's nothing to do with the ZIM but with kiwix-serve, as that puts this frame around iframes it seems. @rgaudin what do you suggest?

@rgaudin
Copy link
Member

rgaudin commented Aug 26, 2020

Absolutely.

@IPECORE, this is a kiwix-serve specific issue. This is not show in other readers (iOS, desktop, android).

The workaround we have at the moment, is to add partial=true to the MIME type of iframes'HTML articles (text/html obviously). We can't do that in zimwriterfs-like mode (nor in plain zimwriterfs).
Once we move away from this mode, we could be able to set it and that annoying bar would not be shown.

@rgaudin rgaudin changed the title topic 5, Unit 2, step 2, task 3. Unnecessary line between text and graphic Hide kiwix-serve taskbar in embedded iframes Aug 26, 2020
@kelson42 kelson42 pinned this issue Sep 4, 2020
@kelson42 kelson42 unpinned this issue Sep 24, 2020
@stale
Copy link

stale bot commented Oct 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants