Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type stubs #198

Closed
rgaudin opened this issue Sep 5, 2024 · 2 comments · Fixed by #199
Closed

Add type stubs #198

rgaudin opened this issue Sep 5, 2024 · 2 comments · Fixed by #199
Assignees
@rgaudin
Labels
enhancement New feature or request
Milestone
3.5.0

Comments

@rgaudin
Copy link
Member

rgaudin commented Sep 5, 2024

We rely on type hints on all projects. We need to create and package stubs for libzim as it is not auto-discovered due to it being a cython extension
@rgaudin rgaudin added the enhancement New feature or request label Sep 5, 2024
@rgaudin rgaudin added this to the 3.5.0 milestone Sep 5, 2024
@rgaudin rgaudin self-assigned this Sep 5, 2024
@benoit74
Copy link

benoit74 commented Sep 5, 2024

Obviously, I would love it!

@rgaudin rgaudin linked a pull request Sep 9, 2024 that will close this issue
Introducing Type Hints #199
Merged
@rgaudin
Copy link
Member Author

rgaudin commented Sep 9, 2024

Fixed in #199

@rgaudin rgaudin closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgaudin rgaudin

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Introducing Type Hints openzim/python-libzim
2 participants
@rgaudin @benoit74