Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit length of ZIM file zimTitle field #677

Open
audiodude opened this issue Nov 8, 2023 · 2 comments
Open

Limit length of ZIM file zimTitle field #677

audiodude opened this issue Nov 8, 2023 · 2 comments
Assignees
Labels

Comments

@audiodude
Copy link
Member

Currently, the customZimTitle field that we send to the zimfarm is copied directly from the Builder name, which has no restrictions on its length, besides being truncated to 255 characters in the database. ZIM titles, on the other hand, can only be 30 characters max.

A couple of options:

  1. Inherit the ZIM restriction and limit Builder titles to 30 characters
  2. Truncate the Builder title when creating a ZIM

I tend to prefer the second option, because I don't see why the limitations of a ZIM should limit the entire WP1 UI.

@audiodude audiodude added the bug label Nov 8, 2023
@audiodude audiodude self-assigned this Nov 8, 2023
@benoit74
Copy link

benoit74 commented Nov 8, 2023

For me option 2 is not very good, because it means that we can get ZIM titles with a last word truncated in the middle (kind of ugly) and also duplicate ZIM titles (for different selections) due to identical first 30 chars among them.

I tend to prefer either option 1 (with a clear warning for the user) or a third option: add the ZIM title to information the user must input when creating a ZIM (just like description and long description) and automatically populate it based on the truncated Builder title. This way, the user will be able to do whatever is needed to make it look good.

@audiodude
Copy link
Member Author

Yes I like this new "option 3" as well: query for a separate ZIM title on the ZIM creation page, that is auto populated with a (possibly truncated) version of the Builder name. Then the user can decide how best to untruncate it.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants