Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikimed AR and JA are not clickable #777

Open
Popolechien opened this issue Jan 6, 2024 · 14 comments
Open

Wikimed AR and JA are not clickable #777

Popolechien opened this issue Jan 6, 2024 · 14 comments
Assignees
Labels
Bug Something isn't working

Comments

@Popolechien
Copy link
Collaborator

Popolechien commented Jan 6, 2024

Looking at Wikimed JA and AR, on both apps' front page none of the links appear clickable.

Links elsewhere in the zim seem to work fine (see, e .g., those here)

This is a major blocker for ../../kiwix/kiwix-android-custom/issues/161

@Popolechien Popolechien added the Bug Something isn't working label Jan 6, 2024
@kelson42
Copy link
Collaborator

@Popolechien These links are not clickable because the target articles are not available. Actually the links should be removed, there is a weakness in MWoffliner here. But at the core of the problem is this kind of modification! MWoffliner has no clue of these new pages.

Special Wikimed pages are hardocoded at https://github.com/openzim/wp1_selection_tools/blob/main/build_custom_selections.sh#L71. And then they should be properly linked via interwiki links.

@RavanJAltaie @Popolechien Can you please secure this is OK for all languages with James?

@kelson42 kelson42 added Bug Something isn't working and removed Bug Something isn't working labels Jan 10, 2024
@Popolechien
Copy link
Collaborator Author

Popolechien commented Jan 11, 2024

Ok we may have a bigger problem here as looking at https://github.com/openzim/wp1_selection_tools/blob/main/build_custom_selections.sh#L71 none of the books seem to exist anymore (see, e.g., Wikipedia:Books/archive/Cardiology).

@Popolechien
Copy link
Collaborator Author

Ah I see the Books extension was deprecated in 2021.

Guess the selection tool would benefit from a bit of freshening up.

@WikiDocJames
Copy link

WikiDocJames commented Jan 14, 2024

Yup the book extension was deleted across most / all versions of WP. So basically in Japanese we moved to using userspace pages. Let me know if anything needs to be done on WP to fix things are if this can be taken care of on your end.

@kelson42
Copy link
Collaborator

@WikiDocJames I think everything is in my comment:

  • All the pages needed in English ahould be properly listed
  • All other localised versions should be linked via interwiki links

@WikiDocJames
Copy link

WikiDocJames commented Jan 14, 2024

Okay so to clarify you are using the EN WP version as a template and then following the interlanguage links via Wikidata to find the corresponding versions in other languages? The problem is that Wikidata will not allow linking to a userspace. I could try moving to Wikipedia space on JA, but not sure it will survive their... Okay done for Japanese. Will look at Arabic in a bit.

@WikiDocJames
Copy link

Looking at Arabic and not sure what the issue is... As it appears to be linked https://www.wikidata.org/wiki/Q115765957#sitelinks-wikipedia

@RavanJAltaie
Copy link
Contributor

I found the problem.
Both Fixed, Arabic & Japanese.
@Popolechien Please double check so I can close the issue

@kelson42 kelson42 reopened this Mar 23, 2024
@kelson42
Copy link
Collaborator

kelson42 commented Mar 23, 2024

@RavanJAltaie AFAIK this is not fixed, please if you fixed something please explain what, at least by providing a link.

Going to fix openzim/wp1_selection_tools#47 first and see if there is somewhere a problem there or somewhere else.

@RavanJAltaie
Copy link
Contributor

The problem was that the link of the landing page was changed and I've updated the recipe, the recipe succeeded but I checked it and the links are still not clickable as follows
image
This is the file
https://library.kiwix.org/viewer#wikipedia_ar_medicine_maxi_2024-03
@benoit74 any idea?

@benoit74
Copy link
Contributor

benoit74 commented Apr 4, 2024

This is probably more a question for @kelson42, he is assigned on the ticket, has already advised on what needed to be done and has far more experience on this topic than I do. Did you understood what was supposed to be done to have this working? If yes, did you checked this has been done? If not, did you asked for more explanation by @kelson42? You need to have an understanding of this kind of issue so that you can diagnose a little bit what is going on. Don't be afraid to ask questions if things are unclear.

@WikiDocJames
Copy link

@RavanJAltaie
Copy link
Contributor

If you search through the library you'll get 3 files for the 3 flavours, maxi, mini, and nopic
I opened three of them and the links inside the file are not clickable
image
The landing page itself is working fine, and it's assigned properly inside the recipe
(Landing page)
I couldn't figure out what's the problem? @kelson42 @Popolechien

@Popolechien
Copy link
Collaborator Author

I couldn't get to the Japanese landing page at https://library.kiwix.org/viewer#wikipedia_ja_medicine_maxi - I've restarted the recipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants