Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parent image to openjdk:8-jdk-alpine? #7

Closed
alicefr opened this issue May 15, 2018 · 8 comments
Closed

Change parent image to openjdk:8-jdk-alpine? #7

alicefr opened this issue May 15, 2018 · 8 comments

Comments

@alicefr
Copy link
Contributor

alicefr commented May 15, 2018

Hi,
I have a question and I hope you could help me.

I wanted to build openzipkin/zipkin docker image for another platform rather than x86. However, the cantara/alpine-zulu-jdk8 has not multi-arch image support. So, I was wondering if it would be possible to change the parent image of openzipkin/jre-full: with the official docker image openjdk:8-jdk-alpine. The openjdk images has already multi-arch support.

Thanks for the help!

@codefromthecrypt
Copy link
Member

Thanks for the idea, Alice. I think the main issue is about the image size.. maybe with the current squashing approach we can handle that? Also, are you available to help with this?

@alicefr
Copy link
Contributor Author

alicefr commented May 22, 2018

hi @adriancole. What are you concerns about the image size?The openjdk image size?
Because on my system (x86_64) the openjdk is smaller than cantara based image

$ docker pull cantara/alpine-zulu-jdk8
$ docker images | grep cantara
cantara/alpine-zulu-jdk8        latest                                     82d6c0ad442e        5 weeks ago         163MB

$ docker pull openjdk:8-jdk-alpine
$ docker images | grep openjdk
openjdk                         8-jdk-alpine                               224765a6bdbe        4 months ago        102MB

I'm glad to help you with that!

I saw that you use docker-squash command. Are you aware of the squash flag for docker build.
It is still an experimental flag, but it may help

@codefromthecrypt
Copy link
Member

codefromthecrypt commented May 22, 2018 via email

@alicefr
Copy link
Contributor Author

alicefr commented May 24, 2018

I will try to substitute the parent image and look at the size. If it is equal or smaller I can open a little PR with the changes. Is that ok for you?

@codefromthecrypt
Copy link
Member

codefromthecrypt commented May 24, 2018 via email

@alicefr
Copy link
Contributor Author

alicefr commented Jun 4, 2018

hi @adriancole! You find here my PR #8

@codefromthecrypt
Copy link
Member

all good. thanks @alicefr!

Next up would be considering JRE 9 :)

@codefromthecrypt
Copy link
Member

images are recut zipkin 2.7.4 is based on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants