Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of metrics-reader ClusterRole #6587

Closed
mohammadne opened this issue Oct 2, 2023 · 5 comments
Closed

usage of metrics-reader ClusterRole #6587

mohammadne opened this issue Oct 2, 2023 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/support Indicates an issue that is a support question.
Milestone

Comments

@mohammadne
Copy link

mohammadne commented Oct 2, 2023

Type of question

Open question

Question

What did you do?

I want to know what is the usage of metrics-reader ClusterRole in rbac, because I don't see any ClusterRoleBinding defined for it and it's always unusable.

What did you expect to see?

I want to delete metrics-reader ClusterRole or define a ClusterRoleBinding and subject it to the ServiceAccount used by the Deployment

Environment

Operator type: /language go

Kubernetes cluster type: k8s cluster deployed via kubespray

$ operator-sdk version v1.31.0

$ go version (if language is Go) 1.19.11

$ kubectl version 1.27

@varshaprasad96
Copy link
Member

This cluster role is scaffolded to allow the prometheus server to scrape metrics. The creation of cluster role binding is left to the user, depending on the namespace where prometheus is available.

More details on its use and on how to create the cluster role binding for the cluster role are available here; https://book.kubebuilder.io/reference/metrics.html?highlight=prometheus#exporting-metrics-for-prometheus

@varshaprasad96 varshaprasad96 added the triage/support Indicates an issue that is a support question. label Oct 2, 2023
@varshaprasad96 varshaprasad96 added this to the Backlog milestone Oct 2, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 31, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Mar 2, 2024
Copy link

openshift-ci bot commented Mar 2, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/support Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

3 participants