-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note about chainsaw #6675
Conversation
Following the discussion we had via Slack, I wanted to share some thoughts on the PR. The operator-sdk includes a feature called scorecard, which utilizes kuttl. This is the reason kuttl is mentioned in the documentation. However, chainsaw is not included or shipped with the project (or is the core of any test feature supported by it). Therefore, I'm not sure if it's appropriate to include it in the documentation. Including chainsaw might lead the operator-sdk maintainers into a situation where they have to answer questions and provide support for a tool that is not a direct part of the project. It can be challenging for maintainers to support third-party tools and integrations. I am no longer an active maintainer of the SDK project, so I'll leave the decision to those currently maintaining the project to determine what best fits their strategy. |
Thanks for chiming in @camilamacedo86 ! Operator SDK can support chainsaw scorecard test, here is the PR #6676 😄 I'm fine with answering chainsaw related questions if any. |
@jberkhahn do you have any suggestion after the yesterday meeting ? what is the next step ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. As a scaffolding tool we are listing the possible options and redirecting user to the external documentation.
Thanks for the PR @eddycharly!
/lgtm
Thanks @varshaprasad96 😍 Do I need to fix something ? |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
@varshaprasad96 i lost your LGTM 🙏 |
Going to go ahead and merge this, as it has been open for review for a few days! If folks have any issues/further discussions w.r.t to this PR, please feel free to create issues :) |
Description of the change:
Add note about chainsaw in the docs.
If you need more infos 👇
Motivation for the change:
We presented chainsaw to the community meeting last week and received good feedback.
It would be awesome to have it listed in the docs.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs