Constraint hashcode equals fix #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt creation to take in sets of constraints as constructor arguments for efficiency
…ce constraints with different weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #206. It updates the hashcode and equals methods of the constraints and adds a test suite to ensure the methods work as expected.
In addition, changed ExistentialConstraint to take sets of constraints as its arguments instead of lists of constraints. This ensures efficient encoding and comparison of ExistentialConstraints.
Changed PreferenceConstraint to not hash or compare on the weight value, since there should never be more than 1 PreferenceConstraint for the same variable and goal.