Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: Creation of dynamic property Optimizely\Utils\CustomAttributeConditionEvaluator::$logger is deprecated #283

Open
benschoch opened this issue Feb 13, 2024 · 0 comments · May be fixed by #284
Open

Deprecated: Creation of dynamic property Optimizely\Utils\CustomAttributeConditionEvaluator::$logger is deprecated #283

benschoch opened this issue Feb 13, 2024 · 0 comments · May be fixed by #284
Labels
enhancement

Comments

@benschoch
Copy link

benschoch commented Feb 13, 2024 •
edited
Loading

Description

There are (at least) 2 remaining deprecated definitions of dynamic properties, in OptimizelyConfigService and CustomAttributeConditionEvaluator.

All properties (at least outside of the tests) should use explicit property definition.

Benefits

Get rid of deprecation infos in runtime.
@benschoch benschoch linked a pull request Feb 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly define class properties benschoch/optimizely-php-sdk
1 participant
@benschoch