Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide policy of file names #118

Open
toshihikoyanase opened this issue Jun 1, 2022 · 1 comment
Open

Decide policy of file names #118

toshihikoyanase opened this issue Jun 1, 2022 · 1 comment
Labels
no-stale Exempt from stale bot

Comments

@toshihikoyanase
Copy link
Member

Motivation

During the review of #91, we found that we had no explicit file name policy.
In my understanding, we followed the following convention implicitly.

  • Create {library_name}_simple.py that demonstrates the Optuna usage without the integration module (e.g., keras_simple.py).
  • Create {library_name}_integration.py that demonstrates the Optuna usage with the integration module (e.g., keras_integration.py).

But some examples integrates the pruning example to simple example and switch the behavior with the --pruning option (See #77).

So, we may need to discuss the naming policy based on the current status.

Description

#77 will reveal the use of integration modules and existence of --pruning option in each example. So, this issue can be revisit after it.

@github-actions
Copy link

This issue has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jun 15, 2022
@nzw0301 nzw0301 added no-stale Exempt from stale bot and removed stale Exempt from stale bot labeling. labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Exempt from stale bot
Projects
None yet
Development

No branches or pull requests

2 participants