Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log all the reconciles where an upgrade happens #165

Open
shyamradhakrishnan opened this issue Sep 20, 2022 · 1 comment
Open

Log all the reconciles where an upgrade happens #165

shyamradhakrishnan opened this issue Sep 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@shyamradhakrishnan
Copy link
Contributor

What would you like to be added:
Log all the reconciles where an upgrade happens. T
his will help in cases where there are spurious upgrades or has defaults returned by OCI API.

Why is this needed:
@shyamradhakrishnan shyamradhakrishnan added the enhancement New feature or request label Sep 20, 2022
@joekr
Copy link
Member

joekr commented Sep 20, 2022

This request came out of PR #163
and what we are looking to do is make our logging better like this example: https://github.com/oracle/cluster-api-provider-oci/blob/main/cloud/scope/managed_machine_pool.go#L515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joekr @shyamradhakrishnan