Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fiber#raise after Fiber#transfer #2342

Closed
eregon opened this issue May 3, 2021 · 2 comments
Closed

Support Fiber#raise after Fiber#transfer #2342

eregon opened this issue May 3, 2021 · 2 comments
Assignees
Milestone

Comments

@eregon
Copy link
Member

eregon commented May 3, 2021

See #2338 (comment)
@bjfish Could you try to implement that?
That's a Ruby 3 change, so we should add the spec in :next.

It does mean we'll need to mark as failing this spec:
https://github.com/ruby/ruby/pull/3795/files#diff-184b163e2d8d9c8d74755a749a8d21df6692d2af454e60d3a747fcc18cfbc2faR81
but I think that's fine, probably nothing relies on that exception.

@ioquatix
Copy link
Contributor

ioquatix commented May 4, 2021

Fiber#raise should use transfer if the fiber was previously transferred out. At least, that's my understanding of how it works currently in Ruby 3.x.

@bjfish
Copy link
Contributor

bjfish commented Nov 5, 2021

I think this is implemented since the spec/test here are passing:
https://github.com/ruby/ruby/pull/3795/files#diff-184b163e2d8d9c8d74755a749a8d21df6692d2af454e60d3a747fcc18cfbc2faR81

Fiber#transfer behavior for Ruby 3 was implemented here:
d59b3fb

Additional Ruby 3 Fiber methods are still work in progress as tracked here:
#2453

@bjfish bjfish closed this as completed Nov 5, 2021
@bjfish bjfish added this to the 22.0.0 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants