Implement beginless range #2155

LillianZ · 2020-11-13T23:16:10Z

Starting to implement beginless ranges for Ruby 2.7 compatibility #2004

So far:
Implemented or added specs for Range#{new, bsearch, count, each, equal_value, first, inspect, max, min, size} regarding beginless range compatibility
Implemented or added specs for Array#{[], []=, slice, slice!, to_a, fill, values_at} regarding beginless range compatibility

To do:
Range#cover?/include/===
some or all of Range#{entires, eql?, hash, last, member?, minmax, step/%, to_s}
Methods outside of Array and Range, such as String methods.

Shopify#1

eregon · 2020-11-17T12:15:54Z

@norswap Could you review this one?

Looks good to me :)

LillianZ · 2020-11-17T14:22:09Z

Is jt format a known issue right now?

norswap · 2020-11-17T14:37:48Z

@LillianZ Do you mean the Eclipse error where it can't find libjvm.dylib on macOS? Then yes. The quickfix is to:

OPENJDK_VERSION=openjdk1.8.0_272-jvmci-20.3-b04 # adapt
cd ~/.mx/cache/truffleruby/$OPENJDK_VERSION/Contents/MacOS/
rm libjli.dylib
ln -s ../Home/jre/lib/jli/libjli.dylib libjli.dylib
cd -

The problem has been known for some time, but it's in limbo as it requires digging into the OpenJDK build process. It's fixed on the GraalVM image builds however.

LillianZ · 2020-11-17T14:45:51Z

Got it, thank you! I misunderstood the error logs. Force-pushed some spacing for lint.

norswap

Looks good to me so far!

Another place I remember I had to handle endless ranges explicitly was StringNodes#GetIndexNode.

src/main/ruby/truffleruby/core/range.rb

graalvmbot · 2020-11-23T16:42:51Z

Hello LillianZ, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address LillianZ -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

eregon · 2020-11-23T16:49:00Z

@LillianZ I can add that email to the list, but it would be better to rebase instead of merge to have a clean history.

graalvmbot · 2020-11-23T17:02:56Z

LillianZ has signed the Oracle Contributor Agreement (based on email address LillianZ -(at)- users -(dot)- noreply -(dot)- github -(dot)- com) so can contribute to this repository.

LillianZ · 2020-11-23T17:08:06Z

Sorry, a conflict appeared online not appearing locally, and trying to resolve it caused a merge. I have been trying to rebase.

eregon · 2020-11-23T17:16:03Z

FWIW, the GitHub UI often thinks there are conflicts in CHANGELOG.md, but actually there isn't due to the union merge strategy which never conflicts. Best is to just ignore those, because there are no actual conflicts.

LillianZ · 2020-11-23T17:26:26Z

To confirm: it's okay ignore when GitHub UI complains about a conflict (at least in CHANGELOG) because it's something you can fix?

…size}

and internal beginless? predicate

LillianZ · 2020-11-25T21:08:49Z

I am slightly concerned that 2.6 specs have been running for 3 hours, but they passed locally so I'm not sure what to do.

chrisseaton · 2020-11-25T21:44:50Z

Looks broken - it's not running at all. CI is hard.

LillianZ · 2020-11-25T22:09:33Z

Thanks for checking! I fixed my commit message to get CI to rerun.

eregon · 2020-11-26T12:27:40Z

Most likely this indicates a spec getting stuck when run on MRI 2.6.6.
Unfortunately it seems GitHub Actions stops the job without any signal or anything to get a chance to show a backtrace.
Locally I could reproduce with:

$ mspec --timeout 60 .
$ ruby /home/eregon/code/mspec/bin/mspec-run --timeout 60 .
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]
[\ | ===============   39%                    | 00:00:33]      0F      0E 
Range#count returns Infinity for endless ranges without arguments or blocks
Example took longer than the configured timeout of 60.0s

So I'll add the --timeout option, that way we'll see which spec got stuck in CI.

chrisseaton · 2020-11-26T17:34:30Z

Looks like it's generating some kind of infinite string or something. We're investigating.

…n 2.6

LillianZ · 2020-11-26T17:51:22Z

It's fixed! For some reason I didn't realize the specs breaking on CRuby 2.6 => fix 2.6 specs.

eregon · 2020-11-27T10:47:36Z

spec/ruby/core/array/fill_spec.rb

+  ruby_version_is "2.7" do
+    it "works with beginless ranges" do
+      [1, 2, 3, 4].fill('x', eval("(nil..2)")).should == ["x", "x", "x", 4]
+      [1, 2, 3, 4].fill(eval("(nil...2)")) { |x| x + 2 }.should == [2, 3, 3, 4]


Could you remove the extra nils here? Also happens in other specs.

norswap · 2020-11-27T17:38:58Z

Failures:

Primitive.infect was removed as taint checking is deprecated in 2.7 and the various tainting methods become no-ops
The Range#max spec is tagged for Ruby 2.7.2, but the fix to that upstream bug is here and it seems to be on a branch tagged for 3.0.

LillianZ · 2020-11-29T00:09:18Z

Woot! everything's finally passing! sorry for the delay, and thanks for all the tips; I found the range#max patch in ruby-lang and definitely would not have known to go looking in github!

PullRequest: truffleruby/2226

norswap · 2020-12-01T17:58:32Z

Merged! Congrats 👍

graalvmbot added the oca-signed label Nov 13, 2020

LillianZ force-pushed the beginlessRange branch 4 times, most recently from 598038c to 1d5401d Compare November 16, 2020 22:56

eregon requested a review from norswap November 17, 2020 12:15

LillianZ force-pushed the beginlessRange branch from 1d5401d to 70e1c24 Compare November 17, 2020 14:44

norswap reviewed Nov 17, 2020

View reviewed changes

src/main/ruby/truffleruby/core/range.rb Outdated Show resolved Hide resolved

LillianZ force-pushed the beginlessRange branch 2 times, most recently from b22b033 to 304493f Compare November 17, 2020 20:11

Lillian Zhang added 9 commits November 23, 2020 12:11

allow beginless Range creation and untag

3975ef9

Array#[] and #slice shared specs for beginless and endless ranges

9f6d450

Implement Array#[] and #slice for beginless ranges

0129ab8

Spec for beginless range to_a

b6f8373

Implement beginless range to_a

9e9a9b0

Specs for Array#[]= for beginless ranges

8233345

Specs for Array#slice! for beginless ranges

6787205

Specs for Array #fill and #values_at with beginless ranges

d43b09b

Fix Range#bsearch specs with infinity bounds

7cb1ea2

LillianZ force-pushed the beginlessRange branch from c83d659 to 2dfc5a2 Compare November 23, 2020 17:24

Lillian Zhang added 2 commits November 25, 2020 12:48

Specs for Range#{count, each, equal_value, first, inspect, max, min, …

1200be8

…size}

Implement Range#{count, size, first, max, min} for beginless ranges

3ab063a

and internal beginless? predicate

LillianZ force-pushed the beginlessRange branch from 920f5ab to d81bbb9 Compare November 25, 2020 18:02

Use Primitive.nil? instead of beginless? and endless?

473bc1a

LillianZ force-pushed the beginlessRange branch from 3b0b2ab to 473bc1a Compare November 25, 2020 22:08

Range#count spec fix: Range#count runs infinitely on endless ranges i…

b145349

…n 2.6

eregon mentioned this pull request Nov 27, 2020

Re-add truffleruby-head to CI jeremyevans/sequel#1737

Merged

eregon reviewed Nov 27, 2020

View reviewed changes

Array specs: remove extraneous nil during range creation

3483fb7

Range#max spec version 2.7.2 -> 3.0

b07bcf0

LillianZ force-pushed the beginlessRange branch from 83a9e9f to c3cdb10 Compare November 28, 2020 23:33

Remove Primitive.infect from Range#inspect

80ff0a2

LillianZ force-pushed the beginlessRange branch from c3cdb10 to 80ff0a2 Compare November 28, 2020 23:53

eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Dec 1, 2020

norswap approved these changes Dec 1, 2020

View reviewed changes

graalvmbot pushed a commit that referenced this pull request Dec 1, 2020

[GR-27281] Implement beginless range (#2155)

8ad54d1

PullRequest: truffleruby/2226

norswap closed this Dec 1, 2020

norswap removed the in-ci The PR is being tested in CI. Do not push new commits. label Dec 1, 2020

LillianZ deleted the beginlessRange branch December 2, 2020 17:36

LillianZ mentioned this pull request Jan 6, 2021

Ruby 2.7: Beginless ranges fully supported #2211

Merged

chrisseaton added the shopify label Feb 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement beginless range #2155

Implement beginless range #2155

LillianZ commented Nov 13, 2020 •

edited

Loading

eregon commented Nov 17, 2020

LillianZ commented Nov 17, 2020

norswap commented Nov 17, 2020

LillianZ commented Nov 17, 2020 •

edited

Loading

norswap left a comment

graalvmbot commented Nov 23, 2020

eregon commented Nov 23, 2020

graalvmbot commented Nov 23, 2020

LillianZ commented Nov 23, 2020

eregon commented Nov 23, 2020

LillianZ commented Nov 23, 2020 •

edited

Loading

LillianZ commented Nov 25, 2020 •

edited

Loading

chrisseaton commented Nov 25, 2020

LillianZ commented Nov 25, 2020

eregon commented Nov 26, 2020

chrisseaton commented Nov 26, 2020

LillianZ commented Nov 26, 2020

eregon Nov 27, 2020 •

edited

Loading

norswap commented Nov 27, 2020

LillianZ commented Nov 29, 2020

norswap commented Dec 1, 2020

Implement beginless range #2155

Implement beginless range #2155

Conversation

LillianZ commented Nov 13, 2020 • edited Loading

eregon commented Nov 17, 2020

LillianZ commented Nov 17, 2020

norswap commented Nov 17, 2020

LillianZ commented Nov 17, 2020 • edited Loading

norswap left a comment

Choose a reason for hiding this comment

graalvmbot commented Nov 23, 2020

eregon commented Nov 23, 2020

graalvmbot commented Nov 23, 2020

LillianZ commented Nov 23, 2020

eregon commented Nov 23, 2020

LillianZ commented Nov 23, 2020 • edited Loading

LillianZ commented Nov 25, 2020 • edited Loading

chrisseaton commented Nov 25, 2020

LillianZ commented Nov 25, 2020

eregon commented Nov 26, 2020

chrisseaton commented Nov 26, 2020

LillianZ commented Nov 26, 2020

eregon Nov 27, 2020 • edited Loading

Choose a reason for hiding this comment

norswap commented Nov 27, 2020

LillianZ commented Nov 29, 2020

norswap commented Dec 1, 2020

LillianZ commented Nov 13, 2020 •

edited

Loading

LillianZ commented Nov 17, 2020 •

edited

Loading

LillianZ commented Nov 23, 2020 •

edited

Loading

LillianZ commented Nov 25, 2020 •

edited

Loading

eregon Nov 27, 2020 •

edited

Loading