-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion: use oci-spec crate for oci spec types #102
Comments
I am definitely not opposed to it, and as a maintainer of a large chunk of those downstream dependencies I don't mind either. It seems like those definitions already have some traction, so it sounds like it would mutually beneficial. The main requirement is that all the types are spec compliant. It looks like they are, but so long as they are, I wouldn't have an objection to using those types instead. @flavio should weigh in as well as he is the other active maintainer here |
I welcome this proposal! |
Yep, that would be a fine place to start |
Howdy! I've been working on implementing the server side of the distribution spec lately and have found https://github.com/containers/oci-spec-rs super useful in interpreting image and index manifests, descriptors, and manifest configs. The types match up to the spec definitions pretty well and even cover some territory missing in this repo's types.
My suggestion is to consider switching over to
oci-spec
in a future breaking changes release. I would even consider performing this refactor myself if the maintainers are open to it (and potentially some of the downstream dependencies if that makes the suggestion more palatable).The reason I'm interested in this is that I have a couple future tools in mind that I think would benefit from the compatibility offered by shared types. For example:
oci-distribution
to create implementations of these traits that enables my registry to act as a pull through cache, or even to duplicate content to downstream registries.Anyway, let me know if this is a contribution you'd be interested in in the future!
The text was updated successfully, but these errors were encountered: