Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a more ergonomic way to handle partial requests #172

Open
thomastaylor312 opened this issue Oct 4, 2024 · 0 comments
Open

Create a more ergonomic way to handle partial requests #172

thomastaylor312 opened this issue Oct 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@thomastaylor312
Copy link
Contributor

The way things work right now (as seen in #171) is that when doing partial requests, the burden is on the user to validate the SHA of the data when complete. What we should create is a new PartialRequestStream (or a better name than that) type that impls Stream and can be constructed from an offset. Honestly this could even just replace the current return types from the blob stream methods. It would need to track current progress if a partial_content response is received and update an internal Digester with all of the data (similar to what VerifyingStream does now) that could be validated when complete. A single response type like this would make things more ergonomic for users and make sure we can validate everything

@thomastaylor312 thomastaylor312 added the enhancement New feature or request label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant