diff --git a/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.html b/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.html index aae188a96..8d857becb 100644 --- a/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.html +++ b/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.html @@ -34,25 +34,39 @@

Policy View

-
-
- - -
-
- - -
+
+ + +
+
+ +
+
+ +
+
+
+ +
+
+ +
+
+ +
+
+
+
diff --git a/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.scss b/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.scss index 19ed35e11..6daef030f 100644 --- a/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.scss +++ b/ui/src/app/pages/datasets/policies.agent/view/agent.policy.view.component.scss @@ -6,6 +6,14 @@ h4 { line-height: 2rem; margin-bottom: 1.5rem; } +.row { + display: flex; + +} +nb-tab { + padding: 0 !important; + overflow: hidden !important; +} nb-card { border: transparent; diff --git a/ui/src/app/pages/sinks/details/sink.details.component.html b/ui/src/app/pages/sinks/details/sink.details.component.html index b545e8b33..d8463242d 100644 --- a/ui/src/app/pages/sinks/details/sink.details.component.html +++ b/ui/src/app/pages/sinks/details/sink.details.component.html @@ -18,7 +18,7 @@

{{strings.propNames.description}}

{{ sink.description }}

-

No Description Added

+

No Description Added

diff --git a/ui/src/app/pages/sinks/view/sink.view.component.html b/ui/src/app/pages/sinks/view/sink.view.component.html index 51b3822f5..fa8897aa3 100644 --- a/ui/src/app/pages/sinks/view/sink.view.component.html +++ b/ui/src/app/pages/sinks/view/sink.view.component.html @@ -70,7 +70,7 @@

{{ strings.sink.view.header }}

-
+
diff --git a/ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.html b/ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.html index d475094ee..e4be3b923 100644 --- a/ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.html +++ b/ui/src/app/shared/components/orb/policy/policy-datasets/policy-datasets.component.html @@ -13,7 +13,7 @@
-
- - -
+ +
diff --git a/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.scss b/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.scss index e21374c8b..1183e2e06 100644 --- a/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.scss +++ b/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.scss @@ -62,15 +62,8 @@ nb-card { } .code-editor { - height: calc(100%); width: calc(100%); padding: calc(1rem); -} - -.code-editor-wrapper { - min-height: 350px; - min-width: 200px; - height: 367px; - width: calc(100%); - display: block; + min-height: 367px; + max-height: 55vh; } diff --git a/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.ts b/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.ts index 2599fbded..3827f5aae 100644 --- a/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.ts +++ b/ui/src/app/shared/components/orb/policy/policy-interface/policy-interface.component.ts @@ -13,6 +13,8 @@ import { AgentPolicy } from 'app/common/interfaces/orb/agent.policy.interface'; import { FormBuilder, FormControl, Validators } from '@angular/forms'; import IStandaloneEditorConstructionOptions = monaco.editor.IStandaloneEditorConstructionOptions; import { OrbService } from 'app/common/services/orb.service'; +import { EditorComponent } from 'ngx-monaco-editor'; + @Component({ selector: 'ngx-policy-interface', @@ -32,8 +34,8 @@ export class PolicyInterfaceComponent implements OnInit, AfterViewInit, OnChange @Input() detailsEditMode: boolean; - @ViewChild('editorComponent') - editor; + @ViewChild(EditorComponent, { static: true }) + editorComponent: EditorComponent; editorOptions: IStandaloneEditorConstructionOptions = { theme: 'vs-dark', @@ -72,6 +74,17 @@ export class PolicyInterfaceComponent implements OnInit, AfterViewInit, OnChange this.detailsEditMode = false; } + getCodeLineCount() { + const editorInstance = this.editorComponent['_editor']; + if (editorInstance) { + const model = editorInstance.getModel(); + editorInstance.layout(); + return model ? model.getLineCount() : 0; + + } + return 0; + } + ngOnInit(): void { this.code = this.policy.policy_data || JSON.stringify(this.policy.policy, null, 2); } diff --git a/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.html b/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.html index 4057269f2..18319c659 100644 --- a/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.html +++ b/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.html @@ -30,9 +30,10 @@

{{ sink?.name }}

-
+
-

{{ sink?.description }}

+

{{ sink?.description }}

+

No description provided

diff --git a/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.scss b/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.scss index 4cc2a27c4..f5826be91 100644 --- a/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.scss +++ b/ui/src/app/shared/components/orb/sink/sink-details/sink-details.component.scss @@ -52,4 +52,9 @@ nb-card { text-align: end; } } -} \ No newline at end of file +} +.italic { + font-style: italic; + font-size: 0.9rem; + color: #d9deee; +}