Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): only generate one operation if it has multiple tags #1812

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix(core): only generate one operation if it has multiple tags #1812

merged 4 commits into from
Jan 15, 2025
+104 −67

Conversation

AllieJonsson
Copy link
Contributor

Status

READY

Description

Fixes #1677

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

soartec-lab
soartec-lab reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllieJonsson
Thanks for the handle on this.

As suggested in the original issue, how about just using the first tag?
That way, we can control the cases where multiple tags occur by inputting OpenAPI.

soartec-lab
soartec-lab reviewed Jan 13, 2025
View reviewed changes
tests/specifications/multiple-tags.yaml Outdated
Comment on lines 26 to 30
Pet:
type: object
oneOf:
- $ref: '#/components/schemas/Dog'
- $ref: '#/components/schemas/Cat'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also an unnecessary definition 👍

@soartec-lab soartec-lab added the bug Something isn't working label Jan 13, 2025
@AllieJonsson
Copy link
Contributor Author

@AllieJonsson Thanks for the handle on this.

As suggested in the original issue, how about just using the first tag? That way, we can control the cases where multiple tags occur by inputting OpenAPI.

Yes, if the user does not set a function for this setting, then the first tag will be used. Do you think this setting is unnecessary? I think the issue stated it would be nice to have

@soartec-lab
Copy link
Member

@AllieJonsson
Yes, I think this setting is unnecessary because you can change the tag to be output by changing the input of OpenAPI. If there is a case that cannot be avoided, I would like to deal with it as a new issue.

soartec-lab
soartec-lab previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@soartec-lab
Copy link
Member

@AllieJonsson
Could you fix conflict ?

@soartec-lab soartec-lab self-assigned this Jan 15, 2025
@AllieJonsson
Copy link
Contributor Author

@AllieJonsson Could you fix conflict ?

@soartec-lab Done!

soartec-lab
soartec-lab approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@soartec-lab soartec-lab merged commit 7314676 into orval-labs:master Jan 15, 2025
2 checks passed
@AllieJonsson AllieJonsson deleted the fix/multi-tags branch January 15, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soartec-lab soartec-lab soartec-lab approved these changes

Assignees

@soartec-lab soartec-lab

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output mode 'tags' issue when operation has multiple tags
2 participants
@AllieJonsson @soartec-lab