fix(msw): simplify combine #1815
Open
+124
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope we had tests for all previously known cases. I also tried all specs in the linked issues, hope I didn't miss any edge case |
melloware
approved these changes
Jan 13, 2025
|
@AllieJonsson this is great! I will let the others review but I know this has been a pain for MSW users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Rewrite
combine.tsa bit to solve some nested all-of, any-of and one-of issues. (hide whitespace in diff view to get a better view of what changed)Fixes #1807
Fixes #1526
Fixes #1692
Todos