Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated CLI command docs #1433

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: remove deprecated CLI command docs #1433

merged 1 commit into from
Jun 26, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jun 13, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jwks and client commands are aliases. Please test and re-add them! So hydra-get-client, update-update-jwks, hydra list clients, ...

@vinckr
Copy link
Member Author

vinckr commented Jun 26, 2023

The jwks and client commands are aliases. Please test and re-add them! So hydra-get-client, update-update-jwks, hydra list clients, ...

Gotcha, readded the aliases and tested, now this PR only removes the deprecated commands no aliases.

Would be helpful if the aliases are listed in the CLI doc (so for example all aliases for client in get client instead of adding a doc for each alias? (for example clients has a lot of aliases: oauth2-client, client, clients, oauth2-clients)

@aeneasr
Copy link
Member

aeneasr commented Jun 26, 2023

That's probably possible!

@aeneasr aeneasr merged commit 62c2a0a into master Jun 26, 2023
7 checks passed
@aeneasr aeneasr deleted the janitor-hydra-cli branch June 26, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants