Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain default claims mapping #1448

Merged
merged 2 commits into from
Jul 10, 2023
Merged

docs: explain default claims mapping #1448

merged 2 commits into from
Jul 10, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 10, 2023

Closes https://github.com/ory-corp/cloud/issues/4857

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

vinckr
vinckr reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
i pushed a small change to avoid the We form. Avoid wefrom MS styleguide

@aeneasr
Copy link
Member Author

aeneasr commented Jul 10, 2023

ty!

@aeneasr aeneasr merged commit 255f402 into master Jul 10, 2023
8 checks passed
@aeneasr aeneasr deleted the close-docs-traits branch July 10, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinckr vinckr vinckr left review comments

@kmherrmann kmherrmann kmherrmann approved these changes

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeneasr @vinckr @kmherrmann