Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consent-verbose code example #1456

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: consent-verbose code example #1456

merged 2 commits into from
Jul 20, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jul 14, 2023

the consent-verbose example is a copy of login-verbose. This patch changes it a correct example code.

https://www.ory.sh/docs/oauth2-oidc/custom-login-consent/flow#consent-endpoint-code-example

I am not 100% sure if this is the correct code example, but that was what we had before from https://github.com/ory/hydra-login-consent-node/blob/master/src/routes/consent.ts

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, maybe use this instead? https://github.com/ory/kratos-selfservice-ui-node/blob/master/src/routes/consent.ts

The kratos-selfservice-ui-node is more up to date i think.

the consent-verbose example was a copy of login-verbose. This patch changes it a correct example code
@vinckr
Copy link
Member Author

vinckr commented Jul 20, 2023

This looks okay, maybe use this instead? https://github.com/ory/kratos-selfservice-ui-node/blob/master/src/routes/consent.ts

The kratos-selfservice-ui-node is more up to date i think.

Hm its a good 100 lines longer. But then again it is the verbose example 🤔

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeneasr aeneasr merged commit ff1289c into master Jul 20, 2023
8 checks passed
@aeneasr aeneasr deleted the vinckr-patch-4124-docs branch July 20, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants