fix: passkey documentation #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aeneasr
approved these changes
Aug 23, 2024
aeneasr
requested changes
Aug 23, 2024
| @@ -78,7 +78,13 @@ import TabItem from '@theme/TabItem'; | |||
| passkey: | |||
| enabled: true | |||
| config: | |||
| display_name: "My Display Name"`}</CodeBlock> | |||
| rp: | |||
| display_name: Your Application name | |||
There was a problem hiding this comment.
This is only needed when self-hosting Ory Kratos. In Ory Network we automatically set these values. Can you please clarify that, by - for example - adding an additional tab instead?
There was a problem hiding this comment.
Updated, please check :)
I found the correct way to set it up here in https://github.com/ory/kratos/blob/68693a43e4e1e3028f17789e72d0b79f6298d139/contrib/quickstart/kratos/all-strategies/kratos.yml#L37
vinckr
reviewed
Sep 27, 2024
vinckr
approved these changes
Sep 27, 2024
aeneasr
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the correct way to set it up here in
https://github.com/ory/kratos/blob/68693a43e4e1e3028f17789e72d0b79f6298d139/contrib/quickstart/kratos/all-strategies/kratos.yml#L37
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments