feat: document ttl for api keys #1899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hperl
requested review from
vinckr,
aeneasr,
zepatrik and
piotrmsc
as code owners
vinckr
requested changes
Sep 25, 2024
| 3. Enter the API Key name and click **Create** | ||
| 4. Copy the created API Key | ||
| 3. Enter the API Key name | ||
| 4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
Suggested change
| 4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. | |
| 4. Select an **expiration** date. It is recommended to always create API keys with an expiry date. |
| 5. Enter the API Key name and click **Create new API key**. | ||
| 6. Copy the created API Key from the prompt that shows at the bottom right of the screen. | ||
| 5. Enter the API Key name | ||
| 6. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
Suggested change
| 6. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. | |
| 6. Select an **expiration** date. It is recommended to always create API keys with an expiry date. |
alnr
reviewed
Sep 26, 2024
| 3. Enter the API Key name and click **Create** | ||
| 4. Copy the created API Key | ||
| 3. Enter the API Key name | ||
| 4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
I disagree with this recommendation. Expiring API keys are a recipe for outages 😆 . Also typo in recommended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
https://github.com/ory-corp/cloud/pull/7011
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments