Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hydra client skip consent #621

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

Jorgagu
Copy link
Contributor

@Jorgagu Jorgagu commented Jun 28, 2023

Related Issue or Design Document

Update Hydra Maestro oauth2clients CR spec to add the skip consent field for the client.

ory/docs#1437
ory/hydra-maester#124

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Jorgagu Jorgagu marked this pull request as ready for review June 28, 2023 10:35
@Demonsthere
Copy link
Collaborator

This is not so straightforward :) Thanks for the PRs but we first need to merge the controller changes and release a new version, them bump the CRD and controller versions here

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the controller image to v0.0.28 and run formatting :)

@Jorgagu
Copy link
Contributor Author

Jorgagu commented Jun 28, 2023

Please update the controller image to v0.0.28 and run formatting :)

Done ✔️

@Jorgagu Jorgagu requested a review from Demonsthere June 28, 2023 12:35
@Demonsthere Demonsthere merged commit 8e92b5e into ory:master Jun 29, 2023
9 of 10 checks passed
@Jorgagu Jorgagu deleted the feat/hydra-skip-consent branch June 29, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants