Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include BASE_PATH when redirecting to welcome #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pucke-dev
Copy link

Related Issue or Design Document

#259

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@@ -57,7 +57,7 @@ registerWelcomeRoute(router)
registerErrorRoute(router)

router.get("/", (req: Request, res: Response) => {
res.redirect(303, "welcome")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is on purpose so that the redirect to welcome is relative and not absolute

Copy link
Author

@pucke-dev pucke-dev Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its still relative, but prefixed with a base path. When using BASE_PATH env the /welcome route also moves to BASE_PATH/welcome, so this redirect shoots into nowhere, and I would ague, this is a inconsistent behavior compared to the other routes. Pls correct me if im wrong @aeneasr

@pucke-dev pucke-dev requested a review from aeneasr July 9, 2023 16:19
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


pucke-uninow seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants