Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrCompletedByStrategy is not an error, but shows up in telemetry as such. #4109

Open
4 of 5 tasks
beanow-at-crabnebula opened this issue Sep 17, 2024 · 0 comments
Open
4 of 5 tasks
Labels
bug Something is not working.

Comments

@beanow-at-crabnebula
Copy link

Preflight checklist

Ory Network Project

No response

Describe the bug

Strategy functions, such as selfservice.strategy.oidc.strategy.Login have multiple branches where they produce the ErrCompletedByStrategy result.

Doing so will mark the span as errored.
image

However this is not actually an error, it's a control flow detail being used like a "break" on the caller of that function.

Reproducing the bug

  1. Configure an OIDC provider for Kratos v1.2.0.
  2. Configure an OTLP exporter for tracing.
  3. Perform a normal, successful OIDC login.
  4. Multiple spans have a false-positive span error.

Relevant log output

No response

Relevant configuration

No response

Version

Kratos (server) v1.2.0

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes with Helm

Additional Context

No response

@beanow-at-crabnebula beanow-at-crabnebula added the bug Something is not working. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant