Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment PKCE autodiscovery #4125

Open
5 tasks done
alnr opened this issue Sep 25, 2024 · 0 comments
Open
5 tasks done

Augment PKCE autodiscovery #4125

alnr opened this issue Sep 25, 2024 · 0 comments
Labels
feat New feature or request.

Comments

@alnr
Copy link
Contributor

alnr commented Sep 25, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

Some providers (Microsoft, Salesforce, maybe more) don't advertise PKCE but do support it.

Describe your ideal solution

We should earmark those providers as supporting PKCE, and when config option pkce==auto in the Kratos OIDC provider configuration, skip autodiscovery and perform PKCE.

The Salesforce docs need updating to reflect Kratos now supports PKCE.

Workarounds or alternatives

Don't have automatic PKCE for some providers and let users configure pkce==force if they want it.

Version

1.2

Additional Context

No response

@alnr alnr added the feat New feature or request. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant