Fix sporadic failures in test of candidates menu #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wait_for_ajax_and_animations` does not fully cover the asynchronous behaviors of the code and also doesn't help with animations. (The relevant animation is already globally disabled via `$.fx.off = true;` but this does not mean code becomes synchronous.) With this change we simply wait for the element to show up instead. Related ticket: https://progress.opensuse.org/issues/164745
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5809 +/- ##
==========================================
- Coverage 98.49% 98.49% -0.01%
==========================================
Files 394 394
Lines 38686 38685 -1
==========================================
- Hits 38102 38101 -1
Misses 584 584 ☔ View full report in Codecov by Sentry. |
perlpunk
approved these changes
Jul 31, 2024
okurz
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for_ajax_and_animationsdoes not fully cover the asynchronous behaviors of the code and also doesn't help with animations. (The relevant animation is already globally disabled via$.fx.off = true;but this does not mean code becomes synchronous.)With this change we simply wait for the element to show up instead.
Related ticket: https://progress.opensuse.org/issues/164745