-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix firewall configuration in Autoyast profile #5839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify how you tested that? As we don't have automatic tests for autoyast yet that matters :)
with |
hm, I don't know if |
The commit message is not very easy to read and contains a few grammar mistakes. This is also technically not fixing anything at this point. What about:
And yes, it would make sense to test this, e.g. by installing it in a VM. |
* Avoid deprecation warning about using firewall property from SuSEfirewall2 times * Use firewalld configuration instead https://progress.opensuse.org/issues/156169 Signed-off-by: ybonatakis <[email protected]>
Updated on 287f0cd |
Configure the firewall properties as SuSEfirewall2 has been replaced by firewalld and the validation produce a warning. FW_CONFIGURATIONS_EXT keeps working so far because is supported but it is deprecated.
from SuSEfirewall2 times
https://progress.opensuse.org/issues/156169