From a71b21cb08c05de1ccbe34e18cf904f86cdbb2a8 Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Fri, 9 Feb 2024 15:33:51 +0100 Subject: [PATCH] Fix and simplify isotovideo test result evaluation With the new isotovideo flag '--exit-status-from-test-results' we can simplify our evaluation of test module results as well as fix the CI usage. --- .github/workflows/isotovideo-action.yml | 5 +---- .github/workflows/isotovideo-check-all-test-modules.yml | 2 +- .github/workflows/isotovideo.yml | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/isotovideo-action.yml b/.github/workflows/isotovideo-action.yml index 078798b..f49c026 100644 --- a/.github/workflows/isotovideo-action.yml +++ b/.github/workflows/isotovideo-action.yml @@ -13,7 +13,4 @@ jobs: run: zypper -n in jq - name: Run isotovideo against test code - run: isotovideo qemu_no_kvm=1 casedir=. - - - name: fail if any test module failed - run: jq .result testresults/result-*.json | grep -v ok && echo "Test modules failed" && exit 1 + run: isotovideo --exit-status-from-test-results qemu_no_kvm=1 casedir=. diff --git a/.github/workflows/isotovideo-check-all-test-modules.yml b/.github/workflows/isotovideo-check-all-test-modules.yml index ee4ab09..b732c60 100644 --- a/.github/workflows/isotovideo-check-all-test-modules.yml +++ b/.github/workflows/isotovideo-check-all-test-modules.yml @@ -13,4 +13,4 @@ jobs: steps: - uses: actions/checkout@v2 - name: Run isotovideo against test code, fail if any test module failed - run: podman run --rm -it -v .:/tests:Z --entrypoint '' registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86-jq /bin/sh -c 'isotovideo qemu_no_kvm=1 casedir=/tests && jq .result testresults/result-*.json | grep -v ok && echo "Test modules failed" && exit 1' + run: podman run --rm -it -v .:/tests:Z --entrypoint '' registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86-jq /bin/sh -c 'isotovideo --exit-status-from-test-results qemu_no_kvm=1 casedir=/tests' diff --git a/.github/workflows/isotovideo.yml b/.github/workflows/isotovideo.yml index a08209b..7117fbb 100644 --- a/.github/workflows/isotovideo.yml +++ b/.github/workflows/isotovideo.yml @@ -8,4 +8,4 @@ jobs: steps: - uses: actions/checkout@v2 - name: Run isotovideo against test code in happy-path scenario - run: podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 qemu_no_kvm=1 casedir=/tests + run: podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 --exit-status-from-test-results qemu_no_kvm=1 casedir=/tests