Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proceed_on_failure parameter to allow retry #20650

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add proceed_on_failure parameter to allow retry #20650

merged 1 commit into from
Nov 15, 2024
+4 −3

Conversation

cedvid
Copy link
Contributor

@cedvid cedvid commented Nov 15, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@dzedro dzedro marked this pull request as ready for review November 15, 2024 12:58
mloviska
mloviska reviewed Nov 15, 2024
View reviewed changes
lib/utils.pm Outdated Show resolved Hide resolved
@mloviska
Copy link
Contributor

Can you update https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/20650/files#diff-47a0a7f15c1bd3166c2ca1c8c3f4f0c7f7beb1b1b5c4d349e4da8cab17e9ae5eR1184 as well, please?

You don't need to adjust the TO, just add the proceed_on_failure parameter pls.

@cedvid cedvid changed the title Increase timeout for nmcli device disconnect Add proceed_on_failure parameter to allow retry Nov 15, 2024
@mloviska mloviska merged commit fec11ff into os-autoinst:master Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloviska mloviska mloviska approved these changes

@dzedro dzedro dzedro approved these changes

@ricardobranco777 ricardobranco777 Awaiting requested review from ricardobranco777 ricardobranco777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedvid @mloviska @dzedro