Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button errors out when sidebar folder selected #40

Open
ajmeese7 opened this issue Jul 31, 2022 · 0 comments
Open

Edit button errors out when sidebar folder selected #40

ajmeese7 opened this issue Jul 31, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request question Further information is requested

Comments

@ajmeese7
Copy link
Member

main folder selected

If I were to click the edit button right now, the console errors out with Cannot read properties of undefined (reading 'path').

There are several different avenues of approach that we could use for this, so I wanted to open this issue to discuss it before I just picked one. Here are a few possible routes, I'm sure there are more that I am forgetting:

  1. Disable the edit button if only a sidebar item is selected
  2. Have a fallback for if the object is undefined, and try to get the mountpoint reference (i.e. home:/) from the sidebar. This would ideally treat the sidebar items as normal directories
@ajmeese7 ajmeese7 added bug Something isn't working enhancement New feature or request question Further information is requested labels Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant