Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for debugging #875

Closed
Closed

Conversation

ThomasBreuer
Copy link
Member

added two modified AutoDoc functions to makedoc.g, which contain Print statements

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #875 (742154a) into master (0c7aab5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files          51       51           
  Lines        4117     4117           
=======================================
  Hits         3113     3113           
  Misses       1004     1004           

@fingolfin
Copy link
Member

It hangs at this point:

AutoDoc: after AutoDocScanFiles
AutoDoc: before WriteDocumentation
Error: The operation was canceled.

I'll restart it again, to see if we can get another hang, and if it is at the same spot.

@fingolfin fingolfin closed this May 11, 2023
@fingolfin fingolfin reopened this May 11, 2023
@fingolfin
Copy link
Member

I've disabled some of the unnecessary CI jobs

@ThomasBreuer
Copy link
Member Author

Current situation:
CI / Julia nightly - macOS-latest (pull_request) Cancelled after 360m.
The output looks as follows.

AutoDoc: before WriteDocumentation
WriteDocumentation with 3 arguments called
WriteDocumentation: after AppendTo
before WriteDocumentation with 4 arguments
after WriteDocumentation with 4 arguments
before WriteDocumentation with 4 arguments
after WriteDocumentation with 4 arguments
before WriteDocumentation with 4 arguments
after WriteDocumentation with 4 arguments
WriteDocumentation: before WriteChunks
Error: The operation was canceled.

I am going to add more Print statements.

added two modified `AutoDoc` functions to `makedoc.g`,
which contain `Print` statements
in the 3 argument method for `WriteDocumentation`
@ThomasBreuer
Copy link
Member Author

ThomasBreuer commented May 15, 2023

Current situation:
CI / Julia 1.8 - macOS-latest (pull_request) Cancelled after 20m
The output looks as follows.

WriteChunks called
AUTODOC_AbsolutePath called
AUTODOC_AbsolutePath: before Process, pwd is '/bin/pwd'
Error: The operation was canceled.

Now the process seems to hang inside Process(Directory(dir), pwd, InputTextNone(), OutputTextString(result, true), []);.

The test CI / Julia nightly - macOS-latest (pull_request) succeeds, the relevant output lines are as follows.

WriteChunks called
AUTODOC_AbsolutePath called
AUTODOC_AbsolutePath: before Process, pwd is '/bin/pwd'
AUTODOC_AbsolutePath: after Process
AUTODOC_AbsolutePath: result is '/Users/runner/work/GAP.jl/GAP.jl/pkg/JuliaInt\
erface/doc
'
AUTODOC_AbsolutePath: result is '/Users/runner/work/GAP.jl/GAP.jl/pkg/JuliaInt\
erface/doc/_Chunks.xml'
leave AUTODOC_AbsolutePath
WriteChunks: after AUTODOC_AbsolutePath
[...]

(Independent of this technical problem with pwd: Why does AutoDoc want to deal with absolute paths? When I use GAPDoc then it is sufficient to prescribe some relative paths, and the documentation files get generated in the right places.)

@fingolfin
Copy link
Member

Aha, so apparently it hangs running pwd via Process. I guess that makes sense given the kind of issue we've been seeing. I'll investigate!

Of course we could just avoid that particular subprocess call in AutoDoc by using the IO_getcwd command available in current versions of the IO package, but that would just hide the deeper issue, not solve it

@fingolfin
Copy link
Member

Closing this for now as #906 should have resolved the issue for now. See also issue #908

@fingolfin fingolfin closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants