Turn hash for GapObj into error #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 75.76% 75.69% -0.08%
==========================================
Files 51 51
Lines 4160 4160
==========================================
- Hits 3152 3149 -3
- Misses 1008 1011 +3
|
ThomasBreuer
approved these changes
Jun 16, 2023
fingolfin
force-pushed
the
mh/forbid-hash
branch
from
6e6d0a0
to
60ee068
Compare
|
It certainly would be good to discuss the hashing issue somewhere, if only so we can point people at it when they ask about it... |
|
@fingolfin Shall we merge this pull request, and then I create a new pull request for improving the documentation? |
|
This is a breaking change, meaning that once this is merged, the next version should be 0.10.0. But there are already a bunch of other changes merged -- perhaps we can make one more 0.9.x release before merging this -- I've made PR #926 in preparation of this. |
... instead of providing a trivial (constant) hash. This may break some trivial applications, but in return it helps us identify code that relies on the useless default hash, i.e., it helps us find performance bottlenecks. This is a breaking change so also increase the package version.
fingolfin
force-pushed
the
mh/forbid-hash
branch
from
60ee068
to
bca8718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of providing a trivial (constant) hash. This may break
some trivial applications, but in return it helps us identify code
that relies on the useless default hash, i.e., it helps us find
performance bottlenecks.
This is a breaking change so also increase the package version.