From a73b844f0b2d32180c5ff84ed6555a3439706a18 Mon Sep 17 00:00:00 2001 From: Benjamin Lorenz Date: Tue, 20 Feb 2024 01:49:32 +0100 Subject: [PATCH] galois_group: fix is_normal call after removed deprecations (#3385) * fix is_normal call after removed deprecations * galois_group: add test from the book --- src/NumberTheory/GaloisGrp/GaloisGrp.jl | 2 +- test/NumberTheory/galthy.jl | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/NumberTheory/GaloisGrp/GaloisGrp.jl b/src/NumberTheory/GaloisGrp/GaloisGrp.jl index 06bd3b68a9a3..385b60638459 100644 --- a/src/NumberTheory/GaloisGrp/GaloisGrp.jl +++ b/src/NumberTheory/GaloisGrp/GaloisGrp.jl @@ -2091,7 +2091,7 @@ function descent(GC::GaloisCtx, G::PermGroup, F::GroupFilter, si::PermGroupElem; local lt if index(G, s) < 100 @vtime :GaloisGroup 2 lt = right_transversal(G, s) - elseif is_normal(G, s) + elseif is_normalized_by(s, G) lt = [one(G)] # I don't know how to get the identity else @vtime :GaloisGroup 2 lt = short_right_transversal(G, s, si) diff --git a/test/NumberTheory/galthy.jl b/test/NumberTheory/galthy.jl index a480d9a838e1..3910a12d8ae4 100644 --- a/test/NumberTheory/galthy.jl +++ b/test/NumberTheory/galthy.jl @@ -30,6 +30,12 @@ Gs, Cs = galois_group(K, algorithm = :Symbolic) @test is_isomorphic(G, Gc) @test is_isomorphic(G, Gs) + + # from the book + K, a = number_field(x^9 - 3*x^8 + x^6 + 15*x^5 - 13*x^4 - + 3*x^3 + 4*x - 1, "a") + G, C = galois_group(K) + @test order(G) == 216 end import Oscar.GaloisGrp: primitive_by_shape, an_sn_by_shape, cycle_structures