Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscar as a dependency prints polymake banner #3502

Closed
lgoettgens opened this issue Mar 8, 2024 · 1 comment · Fixed by oscar-system/Polymake.jl#480
Closed

Oscar as a dependency prints polymake banner #3502

lgoettgens opened this issue Mar 8, 2024 · 1 comment · Fixed by oscar-system/Polymake.jl#480
Labels
bug Something isn't working package: Polymake

Comments

@lgoettgens
Copy link
Member

Describe the bug
When loading a package that has OSCAR as one of its dependencies, additionally to the OSCAR banner, the polymake banner is displayed. This is considered a bug in #92 (comment)

To Reproduce
Create a new project with the following contents:

==> ./Project.toml <==
name = "MWE"
uuid = "232a930c-02f7-46d6-a7d8-e7b291a59d84"

[deps]
Oscar = "f1435218-dba5-11e9-1e4d-f1a5fab5fc13"

==> ./src/MWE.jl <==
module MWE

using Oscar

greet() = print("Hello World!")

end # module MWE

Then execute the following in this folder.

$ julia --project=.
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.2 (2024-03-01)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using MWE
polymake version 4.11
Copyright (c) 1997-2023
Ewgenij Gawrilow, Michael Joswig, and the polymake team
Technische Universität Berlin, Germany
https://polymake.org

This is free software licensed under GPL; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

  ___   ____   ____    _    ____
 / _ \ / ___| / ___|  / \  |  _ \   |  Combining ANTIC, GAP, Polymake, Singular
| | | |\___ \| |     / _ \ | |_) |  |  Type "?Oscar" for more information
| |_| | ___) | |___ / ___ \|  _ <   |  Manual: https://docs.oscar-system.org
 \___/ |____/ \____/_/   \_\_| \_\  |  Version 1.0.0

Expected behavior
To only print the OSCAR banner

System (please complete the following information):

julia> MWE.Oscar.versioninfo(full=true)
OSCAR version 1.0.0
  combining:
    AbstractAlgebra.jl   v0.40.1
    GAP.jl               v0.10.3
    Hecke.jl             v0.30.2
    Nemo.jl              v0.43.1
    Polymake.jl          v0.11.14
    Singular.jl          v0.22.4
  building on:
    Antic_jll               v0.201.500+0
    Arb_jll                 v200.2300.0+0
    Calcium_jll             v0.401.100+0
    FLINT_jll               v200.900.9+0
    GAP_jll                 v400.1200.200+9
    Singular_jll            v403.214.1400+0
    libpolymake_julia_jll   v0.11.4+0
    libsingular_julia_jll   v0.43.0+0
    polymake_jll            v400.1100.1+0
See `]st -m` for a full list of dependencies.

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
Official https://julialang.org/ release

Additional context
same thing happens for current oscar master

@lgoettgens lgoettgens added bug Something isn't working package: Polymake labels Mar 8, 2024
@fingolfin fingolfin changed the title Oscar as a depedency prints polymake banner Oscar as a dependency prints polymake banner Mar 10, 2024
@fingolfin
Copy link
Member

I think this is essentially the same as oscar-system/Polymake.jl#412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: Polymake
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants