Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming vertices_and_rays #4011

Open
YueRen opened this issue Aug 14, 2024 · 0 comments
Open

Renaming vertices_and_rays #4011

YueRen opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code

Comments

@YueRen
Copy link
Member

YueRen commented Aug 14, 2024

Currently, vertices_and_rays does not return vertices and rays, but minimal_faces and rays_modulo_lineality. For the sake of consistency, would it be possible to:

  1. Create an alias vertices_modulo_lineality for minimal_faces.
  2. Rename vertices_and_rays to vertices_and_rays_modulo_lineality.

Alternatively, we could make vertices_and_rays internal and tell users to use minimal_faces and rays_modulo_lineality (as well as their maximal cell incidences) seperately.

@YueRen YueRen added enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Development

No branches or pull requests

1 participant