Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing snake case aliases for IncidenceMatrix #4033

Open
YueRen opened this issue Aug 21, 2024 · 2 comments
Open

Missing snake case aliases for IncidenceMatrix #4033

YueRen opened this issue Aug 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@YueRen
Copy link
Member

YueRen commented Aug 21, 2024

A few types are still missing snake case aliases:

  • PadicField
julia> PadicField(3,10)
Field of 3-adic numbers

julia> padic_field(3,10)
ERROR: MethodError: no method matching padic_field(::Int64, ::Int64)

Closest candidates are:
  padic_field(::Integer; precision, cached, check)
   @ Nemo ~/.julia/packages/Nemo/u9kPx/src/flint/padic.jl:786

Stacktrace:
 [1] top-level scope
   @ REPL[20]:1

  • IncidenceMatrix
julia> IncidenceMatrix([[1,2],[3,4]])
2×4 IncidenceMatrix
[1, 2]
[3, 4]

julia> incidence_matrix([[1,2],[3,4]])
ERROR: MethodError: no method matching incidence_matrix(::Vector{Vector{Int64}})

Closest candidates are:
  incidence_matrix(::Graph{T}) where T<:Union{Directed, Undirected}
   @ Oscar ~/.julia/dev/Oscar/src/Combinatorics/Graphs/functions.jl:639

Stacktrace:
 [1] top-level scope
   @ REPL[23]:1

@YueRen YueRen added the bug Something isn't working label Aug 21, 2024
@joschmitt
Copy link
Member

The $p$-adic fields are now User-Friendly (TM), so one does not need to give the precision. The recommended way of generating a $p$-adic field is now padic_field(3). Or possibly padic_field(3, precision = 10).

@lgoettgens lgoettgens changed the title Missing (or incomplete) snake case aliases for certain types Missing snake case aliases for IncidenceMatrix Sep 16, 2024
@lgoettgens
Copy link
Member

Maybe @benlorenz or @lkastner could have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants