Serialization of Lie algebras #3980

antonydellavecchia · 2024-07-29T08:15:43Z

Implements serialization for Lie Algebras

lgoettgens · 2024-07-29T14:13:53Z

@antonydellavecchia I started duplicating everything that you added for the other two types of Lie algebras. All of them now have different problems I am afraid I need your help with.

AbstractLieAlgebra
needs serialization of SRow
example:

L = lie_algebra(QQ, :A, 2)

LinearLieAlgebra
saving and loading works, but it yields identical (===) objects. And it seems that it does not call the specific load function at all, as loading fails after calling Oscar.reset_global_serializer_state() with some problem with deserializing matrices.
example:

L = general_linear_lie_algebra(QQ, 2)

DirectSumLieAlgebra
examples:

# empty direct sum
L = direct_sum(QQ, LieAlgebra{QQFieldElem}[])

# non-trivial example
L1 = general_linear_lie_algebra(QQ, 2)
L2 = lie_algebra(QQ, :A, 2)
L = direct_sum(L1, L1, L2) # it is important that the first two summands are still identical after saving and loading

Element types for all of these three
but they are essentially the same, as they just contain a parent pointer and a coeff vector (or rather a 1xn matrix)
examples (for all L as above):

x = basis(L, 1) # for one elem
xs = basis(L) # for a vector of elems

Testing
How do I actually test if saving and loading are correct, if they give me the identical (===) object? I rather just compare some properties between original and deserialized.

codecov · 2024-07-30T10:33:54Z

Codecov Report

Attention: Patch coverage is 98.31461% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (61bf7dc) to head (863cc95).
Report is 1 commits behind head on master.

Files	Patch %	Lines
experimental/LieAlgebras/test/RootSystem-test.jl	90.90%	1 Missing ⚠️
experimental/LieAlgebras/test/WeylGroup-test.jl	96.66%	1 Missing ⚠️
experimental/LieAlgebras/test/setup_tests.jl	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3980      +/-   ##
==========================================
+ Coverage   84.58%   84.64%   +0.05%     
==========================================
  Files         597      598       +1     
  Lines       82265    82445     +180     
==========================================
+ Hits        69587    69783     +196     
+ Misses      12678    12662      -16

Files	Coverage Δ
experimental/LieAlgebras/src/LieAlgebras.jl	`100.00% <ø> (ø)`
experimental/LieAlgebras/src/serialization.jl	`100.00% <100.00%> (ø)`
experimental/LieAlgebras/test/RootSystem-test.jl	`98.52% <90.90%> (-1.48%)`	⬇️
experimental/LieAlgebras/test/WeylGroup-test.jl	`97.77% <96.66%> (-2.23%)`	⬇️
experimental/LieAlgebras/test/setup_tests.jl	`95.18% <94.44%> (-0.09%)`	⬇️

... and 3 files with indirect coverage changes

lgoettgens

@antonydellavecchia Thanks a lot for your help with this! I added some comments to things that came up after our discussion when I played around some more.
The problem with empty vectors is worse than expected, see #3983 for details what I found while digging around.
Can you take it from here? Once you are happy with all the changes in this PR, please write your approval in a comment (since Github won't allow you to do it the usual way) and I am then happy to merge.

lgoettgens · 2024-07-30T20:04:10Z

experimental/LieAlgebras/src/serialization.jl

+        save_object(s, get_attribute(L, symbol_prop), symbol_prop)
+      end
+    end
+    # TODO: handle root_system


@HereAround @emikelsons please wait for this TODO to be resolved (ETA end of August) before putting Lie algebras inside your FTheoryTools serialization. Or, alternatively, have a script that re-creates the serialized models so that we can just re-run it once the serialization of Lie algebras changes

Edit: I already managed to resolve this today. But you should have a reliable way to re-generate your FTheoryTools models anyway, since there certainly will be changes to the Lie algebra serialization. (Not necessarily breaking, but adding more information about them and thus e.g. speeding up some operations on them)

Sorry, this slipped my attention.

All good. I have opened #4008 to coordinate this and many other serialization changes for FTheoryTools. In other words, waiting for you and @antonydellavecchia to tell us when/how to proceed.

src/Serialization/containers.jl

src/Serialization/main.jl

src/Serialization/serializers.jl

lgoettgens · 2024-07-31T14:40:46Z

I added serialization for some more Lie algebra related types. This is starting to make fun 😅
@antonydellavecchia could you have a look at the new implementations as well? They seem to work, but maybe I did something too hacky somewhere.

experimental/LieAlgebras/src/serialization.jl

lgoettgens · 2024-08-19T09:53:37Z

#4020 looks really interesting, but will introduce conflicts. Thus I suggest we wait with this until #4020 is merged. To nevertheless get the bugfixes etc. from this PR in master in a timely manner, I extracted them to #4021

lgoettgens · 2024-08-20T15:53:06Z

This is now rebased on top of #4020. Once that and #4030 are merged, I can simplify this PR a bit

experimental/LieAlgebras/test/setup_tests.jl

lgoettgens

This is now finished from my POV. @antonydellavecchia could you please have a look if you see any issues and if not, proceed with the merge?

* some progress on lie algebra serialization * more progress * serialization for SRow * more * fix for general lie algebras * direct sum lie algebras working * remove whitespace * Fix for empty direct sum * Make LieAlgebraElem work * Some optimizations * Add serialization tests * Add serialization of attributes * Add macro for importing serialization functions * Add reference to issue * foo * Add serialization of root systems * Add serialization of weyl groups * Connect Lie algebra and root system serialization * Make attribute serialization work for Lie algebras * Add artifact serialization test --------- Co-authored-by: Lars Göttgens <[email protected]>

antonydellavecchia added the serialization label Jul 29, 2024

lgoettgens added topic: LieAlgebras experimental Only changes experimental parts of the code and removed experimental Only changes experimental parts of the code labels Jul 29, 2024

lgoettgens force-pushed the adv/serialize-lie-algebra branch from f093096 to 45e8db0 Compare July 29, 2024 14:03

lgoettgens force-pushed the adv/serialize-lie-algebra branch from 803459a to bc8c609 Compare July 30, 2024 19:50

lgoettgens mentioned this pull request Jul 30, 2024

Serialization of empty julia containers forgets type parameters #3983

Open

lgoettgens reviewed Jul 30, 2024

View reviewed changes

lgoettgens changed the title ~~Serialization of Lie Algebra~~ Serialization of Lie algebras Jul 30, 2024

lgoettgens marked this pull request as ready for review July 30, 2024 20:19

lgoettgens force-pushed the adv/serialize-lie-algebra branch from 9b5f726 to 30f3b69 Compare July 31, 2024 14:38

antonydellavecchia commented Aug 1, 2024

View reviewed changes

experimental/LieAlgebras/src/serialization.jl Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

lgoettgens marked this pull request as draft August 1, 2024 10:16

HereAround mentioned this pull request Aug 13, 2024

[FTheoryTools] More on serialization of FTheoryTools #4008

Draft

antonydellavecchia mentioned this pull request Aug 19, 2024

Serialize Types with Attributes #4020

Merged

lgoettgens force-pushed the adv/serialize-lie-algebra branch from 30f3b69 to c159012 Compare August 19, 2024 09:42

lgoettgens mentioned this pull request Aug 19, 2024

Serialization fixes #4021

Merged

lgoettgens force-pushed the adv/serialize-lie-algebra branch from c159012 to 524e52d Compare August 19, 2024 13:13

lgoettgens mentioned this pull request Aug 20, 2024

[Lie algebras] misc bugfixes, root system in Lie alg interface, dim_of_simple_module implementation in julia #4030

Merged

lgoettgens force-pushed the adv/serialize-lie-algebra branch from 524e52d to fa2e7ad Compare August 20, 2024 15:52

lgoettgens force-pushed the adv/serialize-lie-algebra branch 3 times, most recently from 8c14f0f to 6ca22ee Compare August 21, 2024 13:21

lgoettgens reviewed Aug 21, 2024

View reviewed changes

experimental/LieAlgebras/test/setup_tests.jl Outdated Show resolved Hide resolved

antonydellavecchia and others added 19 commits August 22, 2024 16:42

some progress on lie algebra serialization

59bf15f

more progress

034d32f

serialization for SRow

66af597

more

0214510

fix for general lie algebras

a7f80a0

direct sum lie algebras working

3b84f2f

remove whitespace

53186b2

Fix for empty direct sum

7c6d84a

Make LieAlgebraElem work

03cd631

Some optimizations

b0ed460

Add serialization tests

e43225f

Add serialization of attributes

d6a7f2a

Add macro for importing serialization functions

d2377c0

Add reference to issue

a75ee7c

foo

df84093

Add serialization of root systems

772f3d2

Add serialization of weyl groups

22958c7

Connect Lie algebra and root system serialization

8f20128

Make attribute serialization work for Lie algebras

a37ff80

lgoettgens force-pushed the adv/serialize-lie-algebra branch from 98d6503 to a37ff80 Compare August 22, 2024 14:47

Add artifact serialization test

863cc95

lgoettgens marked this pull request as ready for review August 22, 2024 15:41

lgoettgens added the experimental Only changes experimental parts of the code label Aug 22, 2024

lgoettgens approved these changes Aug 22, 2024

View reviewed changes

antonydellavecchia merged commit f7601d3 into master Aug 22, 2024
29 checks passed

antonydellavecchia deleted the adv/serialize-lie-algebra branch August 22, 2024 19:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialization of Lie algebras #3980

Serialization of Lie algebras #3980

antonydellavecchia commented Jul 29, 2024

lgoettgens commented Jul 29, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

lgoettgens left a comment

lgoettgens Jul 30, 2024

lgoettgens Jul 31, 2024

HereAround Aug 22, 2024

lgoettgens commented Jul 31, 2024

This comment was marked as outdated.

lgoettgens commented Aug 19, 2024

lgoettgens commented Aug 20, 2024

lgoettgens left a comment

Serialization of Lie algebras #3980

Serialization of Lie algebras #3980

Conversation

antonydellavecchia commented Jul 29, 2024

lgoettgens commented Jul 29, 2024 • edited Loading

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

lgoettgens left a comment

Choose a reason for hiding this comment

lgoettgens Jul 30, 2024

Choose a reason for hiding this comment

lgoettgens Jul 31, 2024

Choose a reason for hiding this comment

HereAround Aug 22, 2024

Choose a reason for hiding this comment

lgoettgens commented Jul 31, 2024

This comment was marked as outdated.

lgoettgens commented Aug 19, 2024

lgoettgens commented Aug 20, 2024

lgoettgens left a comment

Choose a reason for hiding this comment

lgoettgens commented Jul 29, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading