Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Singular_jll and libsingular_julia_jll #723

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

hannes14
Copy link
Member

@hannes14 hannes14 commented Nov 2, 2023

address comments to #722

@fingolfin fingolfin enabled auto-merge (squash) November 2, 2023 10:27
@fingolfin
Copy link
Member

Hmm, there is a CI failure in the OscarCI tests; the output of an absolute_primary_decomposition invocation changed. It was so far:

│ 2-element Vector{Tuple{MPolyIdeal{QQMPolyRingElem}, MPolyIdeal{QQMPolyRingElem}, MPolyIdeal{AbstractAlgebra.Generic.MPoly{nf_elem}}, Int64}}:
│  (ideal(z^2 + 1, y + 1), ideal(z^2 + 1, y + 1), ideal(z - _a, y + 1), 2)
│  (ideal(z^6 + 4*z^3 + 4, y - z^2), ideal(z^3 + 2, y - z^2), ideal(z - _a, y - _a^2), 3)

The final _a^2 now is _a*z....

Is this expected? In particular: Is this a regression? Or a bugfix? Or just randomness?

@hannes14
Copy link
Member Author

hannes14 commented Nov 2, 2023

Singular_jll has a changed absolute_primary_decomposition, in order to address Singular/Singular#1186.
But the ideal in question (z-_a,y-_a*z) is the same as (z-_a,y-a^2) as z=_a here, so both (the old and the new result) are correct.
But why reports OscarCI with julia 1.6 no diffrences?

@fingolfin fingolfin enabled auto-merge (squash) November 4, 2023 19:47
@fingolfin fingolfin merged commit 2be203f into oscar-system:master Nov 4, 2023
11 of 14 checks passed
@hannes14 hannes14 deleted the hs/update_libsingular branch November 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants