Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to AbstractAlgebra renaming #783

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

joschmitt
Copy link
Member

@joschmitt joschmitt commented Feb 16, 2024

Adjust to the upcoming renaming of ordering to internal_ordering in AbstractAlgebra.
Requires Nemocas/AbstractAlgebra.jl#1597 and Nemocas/Nemo.jl#1678.
Closes #784

@joschmitt joschmitt closed this Feb 20, 2024
@joschmitt joschmitt reopened this Feb 20, 2024
@joschmitt
Copy link
Member Author

Got to go and to be released from my side, but I don't know how the Singular(.jl) release process works.

@thofma
Copy link
Collaborator

thofma commented Feb 20, 2024

It's complicated. I will have to cherry-pick it to the release branch, since there has not been any progress on rebuilding libsingular_julia.

@thofma thofma merged commit 17602d6 into oscar-system:master Feb 20, 2024
16 of 27 checks passed
@joschmitt joschmitt deleted the js/ordering branch February 20, 2024 11:23
thofma pushed a commit that referenced this pull request Feb 20, 2024
* Adjust to AbstractAlgebra renaming

* Bump AbstractAlgebra and Nemo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants