Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Probabilities Must be Re-Normalized in Graph for Subgraph Based on Trusted Seeds #83

Open
gh0stwheel opened this issue Oct 16, 2019 · 2 comments

Comments

@gh0stwheel
Copy link

Currently edge probabilities are "normalized" (made to sum to 1) as a pre-processing stage to running Osrank. However if a trusted seed set is used, then the final graph that Osrank runs on will be a subgraph of the original graph.

In that case we need to add a new step to our Osrank implementation where we re-normalize the edge probabilities in the graph after applying the Trustrank-style filter and before simulating the graph traversals.

@adinapoli-mndc
Copy link
Contributor

Hey @andrewpdickson !

I will crosscheck with @MeBrei once she's back, but I suspect you are spot on. Even if we consider the example graph in the paper:

Screenshot 2019-10-17 at 10 27 38

Supposing we run the TrustRank phase and we realise that P1 and A1 need to be pruned, we will now end up in a situation like this:

Screenshot 2019-10-17 at 10 29 29

This is clearly incorrect, because now the outgoing edges from P3 do not sum all to 1.

I suspect that doing this properly with our current graph implementation might not be trivial, but I will start thinking about this in preparation for Merle to be back 😉

Thanks for catching this!

@gh0stwheel
Copy link
Author

For sure @adinapoli-mndc! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants