-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Poorly translated) error from JOSM that doesn't occur in the JOSM mapcss file listed as source #1732
Comments
It is in https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/deprecated.mapcss But as |
That one is for different rules. The one for sidewalk=yes is a few lines below the one you quoted. But that's not the point. The point is:
|
You are right ! The class 9002015 is no more in source file. Delete here That a frontend issue. Since the backend does no more send update. The frontend does not know it has to delete the full class. But as linked to to an existing source (analyser) it show the last source update timestamp. We may have other lost classes. Not sure how to make is list of lost classes, yet. cc @jocelynj |
I think this may be a good start of disappeared classes: I checked with the item_map.py file which rules of the hardcoded classes are now gone: (Also added a test to catch these automatically from now on) |
Thank you for your PR, it is not what I was think about, but interesting to clean item_map. My point was about cleaning the lost classes in the frontend. |
Correct, I phrased it a bit poorly, sorry about that. What I meant was that probably a good start to remove the items corresponding to the classes that I removed from item_map.py from the frontend too. That is, any error still existing on the frontend for any of the classes below, should be removed, because the related mapcss rule doesn't exist anymore either: |
Ok, thank you. I cleaned all this list classes. |
I don't think there's much to be done here in the backend, so I filed osm-fr/osmose-frontend#446 on the frontend for any remaining classes and/or future cases |
The following warnings got my attention:
https://osmose.openstreetmap.fr/en/issues/open?item=9002&class=9002015
{{0.key}}={{0.value}} is unspecific. Please replace ''{{0.value}}'' by ''left'', ''right'' or ''both''.
Reason: someone translated it into Dutch and also translated the directions (which shouldn't be translated), so basically it now suggests to change the tag to
sidewalk=rechts
or so.{{0.key}}={{0.value}} is niet specifiek. Vervang ''{{0.value}}'' door ''links'', ''rechts'' of ''beide''.
Example:
https://osmose.openstreetmap.fr/en/issue/b9c7d0a9-e08a-f320-99ee-19ec07f009c6
According to the error, it originates from https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/deprecated.mapcss
However, this file from JOSM doesn't contain any warning with this exact string: the error thrown by JOSM is
throwWarning: tr("{0} is unspecific", "{0.tag}");
.So this warning doesn't originate from JOSM, even though it's listed as the origin. However, the string doesn't occur in the Transifex translations either: https://github.com/osm-fr/osmose-backend/blob/master/po/osmose-backend.pot
So I'm a bit puzzled:
The text was updated successfully, but these errors were encountered: