Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9001 + 9001001 landuse=construction without construction #2374

Open
maro-21 opened this issue Nov 1, 2024 · 3 comments
Open

9001 + 9001001 landuse=construction without construction #2374

maro-21 opened this issue Nov 1, 2024 · 3 comments

Comments

@maro-21
Copy link

maro-21 commented Nov 1, 2024

landuse=construction without construction is not an error. Sometimes it is impossible to specify what kind of construction it is.
The same with building=construction without construction - I can see that they're building a building, but I don't know what will it be.
Please remove these "errors", because that way we could create thousands of such issues: shop without opening_hours, restaurant without delivery, road without surface etc.

@Famlam
Copy link
Collaborator

Famlam commented Nov 2, 2024

I agree with you, they're annoying (frequently you cannot even see what is being build, residential or retail), but unfortunately these rules result from JOSM and are only imported together with several others:
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L172

Can you report it to them please?

@maro-21
Copy link
Author

maro-21 commented Nov 3, 2024

and are only imported together with several others

Isn't it possible to choose issues to import?

@Famlam
Copy link
Collaborator

Famlam commented Nov 3, 2024

It is, but then we'd disable the entire block of

way[railway=construction][!construction][!construction:railway],
way[highway=construction][!construction][!construction:highway],
area[building=construction][!construction][!construction:building],
area[landuse=construction][!construction][!construction:landuse],
node[traffic_sign=maxspeed][!maxspeed][!/^maxspeed:.+/],
*[actuator=manual][!handle],
*[mechanical_driver=manual][!handle],
node[emergency=fire_hydrant][!fire_hydrant:type],
way[     boundary=administrative][!admin_level],
relation[boundary=administrative][!admin_level],
relation[route=bicycle ][!network][type=route],
relation[route=hiking  ][!network][type=route],
relation[route=foot    ][!network][type=route],
relation[route=horse   ][!network][type=route],
relation[route=piste][!piste:type][type=route],
relation[route=ski  ][!piste:type][type=route],
*[tourism=information][!information],
*[leisure=pitch][!sport],
*[aeroway=terminal][!building],
*[office=government][!government],
*[power=generator][!generator:source],
*[amenity=social_facility][!social_facility],
*[amenity=place_of_worship][!religion],
*[man_made=tower][!tower:type] {
  throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
  group: tr("missing tag");
  assertNoMatch: "node traffic_sign=maxspeed maxspeed:hgv:conditional=\"80 @ (weight>7.5 AND 22:00-05:00)\"";
}

while the only part you'd want to disable is:

way[railway=construction][!construction][!construction:railway],
way[highway=construction][!construction][!construction:highway],
area[building=construction][!construction][!construction:building],
area[landuse=construction][!construction][!construction:landuse],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants