Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make simplify work with geoms other than linestrings #1764

Open
1 of 2 tasks
joto opened this issue Sep 16, 2022 · 1 comment
Open
1 of 2 tasks

Make simplify work with geoms other than linestrings #1764

joto opened this issue Sep 16, 2022 · 1 comment

Comments

@joto
Copy link
Collaborator

joto commented Sep 16, 2022 •
edited
Loading

The simplify() function currently only works for linestrings.

  • It should also work for multilinestrings.
  • It should also work for (multi)polygons.

The problem with simplify is

a) there are many different algorithms which have different properties (I believe only Douglas-Peucker is implemented in boost::geometry which we use)
b) simplification can make geometries invalid, which is bad and we usually guarantee that we only import valid geometries. This is especially bad for polygons.

See #1663.
@joto
Copy link
Collaborator Author

joto commented Oct 3, 2022

See also https://github.com/kleunen/boost_geometry_simplify

@danieldegroot2 danieldegroot2 mentioned this issue Dec 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joto