Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep using location arrow icon while Driving in Snap to road mode #3564

Closed
2 tasks done
vshcherb opened this issue Apr 6, 2024 · 4 comments · May be fixed by #3675
Closed
2 tasks done

Keep using location arrow icon while Driving in Snap to road mode #3564

vshcherb opened this issue Apr 6, 2024 · 4 comments · May be fixed by #3675
Assignees
@alex-osm
Labels
doc-✅ navigation
Milestone
4.8-iOS

Comments

@vshcherb
Copy link
Member

vshcherb commented Apr 6, 2024 •
edited by alex-osm
Loading

To do:

  • In snap to road mode (navigation) don't use circle (location at rest) icon and only use navigation
  • Use bearing from snapped road
if (bearingValid && (speedValid || isLocationSnappedToRoad())) {
				return hasBearing ? location.getBearing() : lastBearingCached;
			}

Migrate this pull request to iOS osmandapp/OsmAnd#19393

Originally posted by @vshcherb in #3553 (comment)
@vshcherb vshcherb added this to the 4.8-iOS milestone Apr 6, 2024
@Skalii Skalii linked a pull request May 7, 2024 that will close this issue
fix snap to road #3675
Draft
@nnngrach nnngrach assigned nnngrach and unassigned nnngrach May 21, 2024
@DmitryAlexei
Copy link

Related Android (OpenGL) task osmandapp/OsmAnd#19706

@vshcherb
Copy link
Member Author

I don't think it's related task probably another issue

alex-osm added a commit that referenced this issue Aug 12, 2024
@alex-osm
Fix #3564
44c21ca
@alex-osm
Copy link
Contributor

44c21ca

@dmpr0 dmpr0 reopened this Sep 13, 2024
@dmpr0 dmpr0 closed this as completed Sep 13, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Sep 13, 2024

Done

With Navigation Without navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-osm alex-osm

Labels
doc-✅ navigation
Projects
None yet
Milestone
4.8-iOS
Development

Successfully merging a pull request may close this issue.

fix snap to road osmandapp/OsmAnd-iOS
8 participants
@vshcherb @dmpr0 @Skalii @nnngrach @alex-osm @shurasmiling @DmitrySvetlichny @DmitryAlexei