Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in account proposed:highways #449

Open
joostschouppe opened this issue Nov 15, 2023 · 2 comments
Open

Take in account proposed:highways #449

joostschouppe opened this issue Nov 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@joostschouppe
Copy link
Member

This road was added to OSM a while ago: https://www.openstreetmap.org/way/1020654834/history
It's just a road to be constructed, the gov data shouldn't show it as an existing road (probably, the imagery might be outdated of course). So there's tasks in the area, eg https://maproulette.org/challenge/24090/task/196995041

@jbelien jbelien added the enhancement New feature or request label Nov 26, 2023
@jbelien
Copy link
Member

jbelien commented Nov 26, 2023

Shouldn't be an issue!
What's the exact tag you want to include ?
Here is where the logic happens (for Flanders): https://github.com/osmbe/road-completion/blob/master/data/netherlands/netherlands.sh#L18-L25

@joostschouppe
Copy link
Member Author

Just like you now include highway=, I'd suggest including all proposed:highway= objects. Possibly the same for construction:highway=*
One downside is that if we have a proposed/construction highway in OSM already, and the external data correctly evolves from construction to existing road, we wouldn't detect that change.
We could exclude all of the proposed/construction highways on the OSM side to fix that, but in Flanders that would give us an issue because so many roads in their dataset are mapped as "existing" when they are really only just proposed.
The fact of the matter is we treat highway=construction and highway=proposed differently or not in the future, it makes no sense to treat proposed:highway differently from highway=proposed. So for now I'd say we should indeed add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants