Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates should be expressed in ISO-8601 format #166

Open
2 tasks
b-jazz opened this issue Dec 26, 2017 · 3 comments
Open
2 tasks

Dates should be expressed in ISO-8601 format #166

b-jazz opened this issue Dec 26, 2017 · 3 comments
Labels

Comments

@b-jazz
Copy link

b-jazz commented Dec 26, 2017

  • **I'm submitting a ... **
  • [X ] bug report
  • feature request
  • support / question

Brief Description

When entering dates in the filter for thanksgiving to christmas, 11/23/2017 -> 12/25/2017 doesn't work because it expects a format that is specific to a particular region of the world that I'm not familiar with. It would be much better if YYYY-MM-DD format was used for the dates since that is a clear, international standard for representing dates.

What is the current behaviour, (attach relevant screenshots) ?

What is the expected behaviour ?

When does this occur ?

How do we replicate the issue ?

Please tell us about your environment:

Other Information / context:

@willemarcel
Copy link
Collaborator

Hi @b-jazz

Thank you for your report! Are you trying to filter the edits using OSMCha, right?

@batpad
Copy link
Collaborator

batpad commented Dec 27, 2017

Thanks for the report @b-jazz -- @willemarcel the date format seems to be defined and hard-coded here: https://github.com/mapbox/osmcha-frontend/blob/master/src/components/filters/date.js#L50

I would definitely be in favour of either adapting to user's locale or following a more standard YYYY-MM-DD. Obligatory xkcd

@batpad batpad added the bug label Dec 27, 2017
@b-jazz
Copy link
Author

b-jazz commented Dec 27, 2017

@illemarcel that's correct, on the filter page. @batpad thanks for clarifying and including the perfect XKCD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants