Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of GitHub releases #127

Open
SMillerDev opened this issue Jun 21, 2024 · 4 comments
Open

Usage of GitHub releases #127

SMillerDev opened this issue Jun 21, 2024 · 4 comments

Comments

@SMillerDev
Copy link

I'm a maintainer for Homebrew, and when working on some style issues in casks I found that this software embeds releases in the repo, which is highly unusual and probably pretty bad for git performance.
Would you consider adding the releases to the GitHub releases and tags so they are easier to find for people?

@ospfranco
Copy link
Owner

hey, I think the releases folder was necessary for sparkle, can't remember. The homebrew listing was contributed in a PR so I don't really know how it works.

Moving to releases would be better indeed, but I'm going on vacation next week for 3 months, so I doubt I will get to it.

If you provide me with some docs I can try to take a look when I'm back.

@SMillerDev
Copy link
Author

Don't worry about the Homebrew part. Nothing is wrong there. Enjoy your holiday, here's an apidoc about release assets for when you return: https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28

@ospfranco
Copy link
Owner

ospfranco commented Jun 21, 2024

The problem is sparkle and the generation of the binaries. I have everything setup on my machine, because it is easy with notarization. Having to setup everything on github actions or even on my machine will be time consuming. Given that this is a hobby project of mine and I make 0 moneys out of it... this will be not my prio... even for this year I guess :)

@ospfranco
Copy link
Owner

I've recently migrated to using github releases with sparkle as well, this should be working now, though I'm not 100% sure I did not break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants